-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crypto): add crypto module with signature verification functionality #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @yair-starkware)
a discussion (no related file):
What's the goal of this PR? why wrap starknet_crypto instead of just using it?
src/crypto.rs
line 52 at r1 (raw file):
&signature.s.into(), ) .map_err(|err| match err {
Extract to impl From
Also, why not just use starknet_crypto::VerifyError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ShahakShama and @yair-starkware)
a discussion (no related file):
Previously, ShahakShama wrote…
What's the goal of this PR? why wrap starknet_crypto instead of just using it?
discussed
src/crypto.rs
line 52 at r1 (raw file):
Previously, ShahakShama wrote…
Extract to
impl From
Also, why not just use starknet_crypto::VerifyError?
I need to pass additional data for the error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
849af44
to
290210c
Compare
290210c
to
bb0b9b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
This change is