Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): add crypto module with signature verification functionality #166

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

yair-starkware
Copy link
Collaborator

@yair-starkware yair-starkware commented Dec 25, 2023

This change is Reviewable

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @yair-starkware)

a discussion (no related file):
What's the goal of this PR? why wrap starknet_crypto instead of just using it?



src/crypto.rs line 52 at r1 (raw file):

        &signature.s.into(),
    )
    .map_err(|err| match err {

Extract to impl From
Also, why not just use starknet_crypto::VerifyError?

Copy link
Collaborator Author

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ShahakShama and @yair-starkware)

a discussion (no related file):

Previously, ShahakShama wrote…

What's the goal of this PR? why wrap starknet_crypto instead of just using it?

discussed



src/crypto.rs line 52 at r1 (raw file):

Previously, ShahakShama wrote…

Extract to impl From
Also, why not just use starknet_crypto::VerifyError?

I need to pass additional data for the error

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware added this pull request to the merge queue Dec 26, 2023
@yair-starkware yair-starkware removed this pull request from the merge queue due to a manual request Dec 26, 2023
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware added this pull request to the merge queue Dec 26, 2023
Merged via the queue into main with commit c7eff8b Dec 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants