Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixate parity_scale_codec on 3.6.5 to fix error in udeps #158

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

yair-starkware
Copy link
Collaborator

@yair-starkware yair-starkware commented Dec 10, 2023

This change is Reviewable

@yair-starkware yair-starkware self-assigned this Dec 10, 2023
@yair-starkware yair-starkware force-pushed the yair/fixate_parity_scale_codec branch from a72676c to 48df14d Compare December 10, 2023 11:12
@yair-starkware yair-starkware changed the title Yair/fixate parity scale codec Fixate parity_scale_codec on 3.6.5 to fix error in udeps Dec 10, 2023
dan-starkware
dan-starkware previously approved these changes Dec 10, 2023
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)


Cargo.toml line 19 at r1 (raw file):

indexmap = { version = "1.9.2", features = ["serde"] }
once_cell = "1.17.1"
# TODO: Remove the explicit version once the following issue is resolved: https://github.com/paritytech/parity-scale-codec/issues/520

I don't think it relates to the same issue

Code quote:

https://github.com/paritytech/parity-scale-codec/issues/520

@yair-starkware
Copy link
Collaborator Author

Cargo.toml line 19 at r1 (raw file):

Previously, dan-starkware wrote…

I don't think it relates to the same issue

changed

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware added this pull request to the merge queue Dec 10, 2023
Merged via the queue into main with commit 2ea2004 Dec 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants