Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump action versions on CI for consistency #146

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Nov 6, 2023

We are already using these versions on some of the tasks here, this is just for consistency across the different tasks.


This change is Reviewable

@giladchase giladchase force-pushed the gilad/bump-action-versions branch from eb52309 to cd0a1c7 Compare November 6, 2023 12:17
@giladchase giladchase changed the base branch from main to gilad/fix-genco-dep November 6, 2023 12:22
elintul
elintul previously approved these changes Nov 6, 2023
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Base automatically changed from gilad/fix-genco-dep to main November 6, 2023 12:36
@giladchase giladchase dismissed elintul’s stale review November 6, 2023 12:36

The base branch was changed.

We are already using these versions on some of the tasks here, this is
just for consistency across the different tasks.
@giladchase giladchase force-pushed the gilad/bump-action-versions branch from cd0a1c7 to c3bb831 Compare November 6, 2023 12:37
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 33a59e7 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants