-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_os): add more missing fields in OS input #3992
feat(starknet_os): add more missing fields in OS input #3992
Conversation
7e314e6
to
3623bce
Compare
fca338d
to
e086777
Compare
3623bce
to
887aff2
Compare
e086777
to
25cc6fd
Compare
887aff2
to
bbf73b6
Compare
25cc6fd
to
efebb91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @aner-starkware and @Yoni-Starkware)
crates/starknet_os/src/io/os_input.rs
line 34 at r1 (raw file):
_deprecated_compiled_classes: HashMap<ClassHash, ContractClass>, _compiled_classes: HashMap<ClassHash, CasmContractClass>, _chain_info: ChainInfo,
instead of general config. Seems to contain exactly the fields of the general config required in the OS
Code quote:
_chain_info: ChainInfo,
bbf73b6
to
bc590a4
Compare
efebb91
to
f18fa20
Compare
Previously, dorimedini-starkware wrote…
Really? Maybe worth refactoring on the python side as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
crates/starknet_os/src/io/os_input.rs
line 34 at r1 (raw file):
Previously, aner-starkware wrote…
Really? Maybe worth refactoring on the python side as well?
not urgent, the chain info is contained in the general config; we can convert as we go.
the ambassador service itself still requires the general config anyway IIUC, so I don't see the major benefit
bc590a4
to
c055600
Compare
f18fa20
to
f28cdbd
Compare
c055600
to
7fb5481
Compare
f28cdbd
to
5ed95a2
Compare
7fb5481
to
9ae0fa5
Compare
5ed95a2
to
436ec49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
f5ee312
to
832bf38
Compare
436ec49
to
7ded8bf
Compare
7ded8bf
to
ca9e47b
Compare
Merge activity
|
No description provided.