Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_os): add more missing fields in OS input #3992

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review February 5, 2025 17:08
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from 7e314e6 to 3623bce Compare February 5, 2025 17:10
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from fca338d to e086777 Compare February 5, 2025 17:10
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from 3623bce to 887aff2 Compare February 5, 2025 21:28
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from e086777 to 25cc6fd Compare February 5, 2025 21:28
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from 887aff2 to bbf73b6 Compare February 5, 2025 21:36
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from 25cc6fd to efebb91 Compare February 5, 2025 21:37
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @aner-starkware and @Yoni-Starkware)


crates/starknet_os/src/io/os_input.rs line 34 at r1 (raw file):

    _deprecated_compiled_classes: HashMap<ClassHash, ContractClass>,
    _compiled_classes: HashMap<ClassHash, CasmContractClass>,
    _chain_info: ChainInfo,

instead of general config. Seems to contain exactly the fields of the general config required in the OS

Code quote:

_chain_info: ChainInfo,

@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from bbf73b6 to bc590a4 Compare February 6, 2025 08:04
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from efebb91 to f18fa20 Compare February 6, 2025 08:04
@aner-starkware
Copy link
Contributor

crates/starknet_os/src/io/os_input.rs line 34 at r1 (raw file):

Previously, dorimedini-starkware wrote…

instead of general config. Seems to contain exactly the fields of the general config required in the OS

Really? Maybe worth refactoring on the python side as well?

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)


crates/starknet_os/src/io/os_input.rs line 34 at r1 (raw file):

Previously, aner-starkware wrote…

Really? Maybe worth refactoring on the python side as well?

not urgent, the chain info is contained in the general config; we can convert as we go.
the ambassador service itself still requires the general config anyway IIUC, so I don't see the major benefit

@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from bc590a4 to c055600 Compare February 6, 2025 14:40
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from f18fa20 to f28cdbd Compare February 6, 2025 14:40
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from c055600 to 7fb5481 Compare February 6, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from f28cdbd to 5ed95a2 Compare February 6, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch from 7fb5481 to 9ae0fa5 Compare February 6, 2025 15:33
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from 5ed95a2 to 436ec49 Compare February 6, 2025 15:33
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_compiled_classes_in_os_input branch 2 times, most recently from f5ee312 to 832bf38 Compare February 6, 2025 16:29
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from 436ec49 to 7ded8bf Compare February 6, 2025 16:29
@dorimedini-starkware dorimedini-starkware changed the base branch from 02-05-feat_starknet_os_compiled_classes_in_os_input to main February 6, 2025 16:59
@dorimedini-starkware dorimedini-starkware force-pushed the 02-05-feat_starknet_os_add_more_missing_fields_in_os_input branch from 7ded8bf to ca9e47b Compare February 6, 2025 17:01
Copy link

graphite-app bot commented Feb 6, 2025

Merge activity

  • Feb 6, 12:01 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 50157f3 Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants