-
Notifications
You must be signed in to change notification settings - Fork 89
Conversation
40d0dac
to
160b4f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
=======================================
Coverage 73.67% 73.67%
=======================================
Files 127 127
Lines 16268 16268
Branches 16268 16268
=======================================
Hits 11985 11985
Misses 2890 2890
Partials 1393 1393 ☔ View full report in Codecov by Sentry. |
Can this depend on the trait somehow? Code quote: let random_op = rng.gen_range(0..3); |
ff6946b
to
b1cc44b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refrain from using test
in test names.
Reviewed 3 of 4 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)
b529875
to
aca6612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)
aca6612
to
d6f9412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion
a discussion (no related file):
- I don't see your comments in reviewable, so I changed what I remember we talked about
- There are several changes because of rebase (mainly imports)
- the constants were changed to include more options now locally; this test runs ~3 seconds
d6f9412
to
889e45d
Compare
4ba9c91
to
5f7a740
Compare
c14bda5
to
edc7a61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r6, 2 of 4 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @DvirYo-starkware)
a discussion (no related file):
@eranreshef-starkware PTAL at the CI part
.github/workflows/ci.yml
line 243 at r9 (raw file):
- uses: dtolnay/rust-toolchain@stable - run: DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1 docker build -f papyrus_utilities.Dockerfile .
Just a new line
Code quote:
···
crates/papyrus_storage/src/db/table_types/dup_sort_tables_test.rs
line 15 at r9 (raw file):
#[test] fn common_prefix_compare_with_simple_table_random() { println!("START");
Please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*.yml
files look OK
d92a92c
to
1c72bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r12, 2 of 2 files at r13, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)
* test(storage): add random table test * CR fix * Fix ci * CR fix
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)