-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mempool): add docstring for queued transaction #416
refactor(mempool): add docstring for queued transaction #416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 83.37% 83.54% +0.17%
==========================================
Files 37 37
Lines 1720 1720
Branches 1720 1720
==========================================
+ Hits 1434 1437 +3
+ Misses 210 206 -4
- Partials 76 77 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MohammadNassar1)
crates/mempool/src/transaction_queue.rs
line 53 at r1 (raw file):
} /// `TransactionQueue` is used to order transactions by priority.
Refrain from using code object names in doc., as it might become outdated.
Suggestion:
Encapsulates a transaction reference to assess its order (or: priority).
0d108d6
to
a32a804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @elintul)
crates/mempool/src/transaction_queue.rs
line 53 at r1 (raw file):
Previously, elintul (Elin) wrote…
Refrain from using code object names in doc., as it might become outdated.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)
This change is