Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add parse_and_commit #309

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

aner-starkware
Copy link
Contributor

@aner-starkware aner-starkware commented Jul 15, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (8dbc268) to head (00cc8f8).

Files Patch % Lines
crates/committer_cli/src/commands.rs 0.00% 4 Missing ⚠️
crates/committer_cli/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   70.65%   70.51%   -0.14%     
==========================================
  Files          38       38              
  Lines        2082     2086       +4     
  Branches     2082     2086       +4     
==========================================
  Hits         1471     1471              
- Misses        541      545       +4     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.455 ms 33.508 ms 33.577 ms]
change: [-6.0131% -4.3556% -2.8695%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
5 (5.00%) high mild
6 (6.00%) high severe

full_committer_flow performance improved 😺
full_committer_flow time: [28.411 ms 28.441 ms 28.472 ms]
change: [-1.7476% -1.5607% -1.3945%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.485 ms 33.530 ms 33.582 ms]
change: [-4.6602% -3.3151% -2.1783%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
5 (5.00%) high mild
6 (6.00%) high severe

full_committer_flow performance improved 😺
full_committer_flow time: [28.531 ms 28.567 ms 28.604 ms]
change: [-2.1059% -1.5671% -1.1512%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @TzahiTaub)


crates/committer_cli/benches/committer_bench.rs line 69 at r1 (raw file):

    //     let committer_input = parse_input(input_str).expect("Failed to parse the given input.");
    //     commit(committer_input, OUTPUT_PATH.to_owned()).await;
    // }

delete


crates/committer_cli/src/main.rs line 74 at r1 (raw file):

    match args.command {
        Command::Commit { output_path } => {
            // TODO(Aner, 15/7/24): try moving read_from_stdin into function.

not sure this is really important; current method seems fine. your call

Code quote:

// TODO(Aner, 15/7/24): try moving read_from_stdin into function.

@aner-starkware aner-starkware force-pushed the aner/benchmark_main_instead_of_commit branch from 70dd03f to 00cc8f8 Compare July 15, 2024 13:57
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @TzahiTaub)

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.491 ms 33.677 ms 33.960 ms]
change: [-3.6024% -2.4917% -1.3108%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe

full_committer_flow performance improved 😺
full_committer_flow time: [28.422 ms 28.466 ms 28.516 ms]
change: [-2.2216% -2.0143% -1.8260%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @TzahiTaub)

Copy link
Contributor Author

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python side: https://reviewable.io/reviews/starkware-industries/starkware/35461#-

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)


crates/committer_cli/src/main.rs line 74 at r1 (raw file):

Previously, dorimedini-starkware wrote…

not sure this is really important; current method seems fine. your call

I'll look into it today\tomorrow; if I don't find a good solution, I'll just delete the TODO.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)

@aner-starkware aner-starkware added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 7dae032 Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants