Checking if any syscall libfuncs are used.

[orizi]

Having the problematic libfunc in the message.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/bin/cairo-execute/src/main.rs line 68 at r1 (raw file):

    ignore_warnings: bool,
    /// Allow syscalls in the program.
    #[arg(long, conflicts_with = "prebuilt")]

why does this conflict?

Code quote:

conflicts_with = "prebuilt")]

[ilyalesokhin-starkware]

crates/cairo-lang-executable/src/compile.rs line 179 at r1 (raw file):

            }
        }
    }

isn't it better to check for usage of the system ptr?

Code quote:

    if !config.allow_syscalls {
        for libfunc in &sierra_program.libfunc_declarations {
            if libfunc.long_id.generic_id.0.ends_with("_syscall") {
                anyhow::bail!(
                    "The function is using libfunc `{}`. Syscalls are not supported in \
                     `#[executable]`.",
                    libfunc.long_id.generic_id
                );
            }
        }
    }

[ilyalesokhin-starkware]

Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @ArielElp and @orizi)

---

crates/cairo-lang-executable/src/compile.rs line 57 at r1 (raw file):

    /// If true, will allow syscalls in the program.
    ///
    /// In general, syscalls are not allowed in executables, as they are currently not checked.

Suggestion:

verified

[orizi]

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @ArielElp and @ilyalesokhin-starkware)

---

crates/cairo-lang-executable/src/compile.rs line 179 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

isn't it better to check for usage of the system ptr?

it seems it is give a clearer cause to the use of what caused them to use the System ptr.

---

crates/cairo-lang-executable/src/compile.rs line 57 at r1 (raw file):

    /// If true, will allow syscalls in the program.
    ///
    /// In general, syscalls are not allowed in executables, as they are currently not checked.

Done.

[orizi]

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @ArielElp and @ilyalesokhin-starkware)

---

crates/bin/cairo-execute/src/main.rs line 68 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

why does this conflict?

because it was already built - you can't even check this.

[ilyalesokhin-starkware]

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)