feat: integers into ContractAddress #7185
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MagisterDaIlis)
a discussion (no related file):
it is missing - but why is it actually necessary?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
a discussion (no related file):
Previously, orizi wrote…
it is missing - but why is it actually necessary?
I was writing tests for my contracts, iterating over a range of u64 numbers that represented contract addresses, and could not convert them to the proper type for my contract interactions because of missing impls.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MagisterDaIlis)
a discussion (no related file):
Previously, MagisterDaIlis wrote…
I was writing tests for my contracts, iterating over a range of u64 numbers that represented contract addresses, and could not convert them to the proper type for my contract interactions because of missing impls.
it is very weird that u64 numbers represented contract addresses.
i would probably expect felt252s in this case (which do have a conversion into a contract address)
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
a discussion (no related file):
Previously, orizi wrote…
it is very weird that u64 numbers represented contract addresses.
i would probably expect felt252s in this case (which do have a conversion into a contract address)
Yes I could force these values to be felt252s, it's for tests only anyway. But I don't understand why restricting conversion from integers to contract addresses
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MagisterDaIlis)
a discussion (no related file):
Previously, MagisterDaIlis wrote…
Yes I could force these values to be felt252s, it's for tests only anyway. But I don't understand why restricting conversion from integers to contract addresses
first of all - you shouldn't ever have a contract address as u64 (as it is a result of a hash) - so i wouldn't recommend it.
second of all - logically - an address here is not just a numeric type - as it is mostly an actual address.
This was missing. Now i can do things like
let c: ContractAddress = 1_u64.into()orlet c: ContractAddress = 1_u256.try_into().unwrap()