Delegated PluginSuite initialization outside RootDatabaseBuilder

[integraledelebesgue]

Stack:

• Migrated the compiler to per-crate plugin queries #6843
• Removed shared databases from tests #6842
• Redesigned semantic testing utilities #6841
• Introduced queries for crate plugins in DefsGroup and SemanticGroup #6840
• Introduced DynEq + DynHash bounds for MacroPlugin, InlineMacroExprPlugin and AnalyzerPlugin traits #6839
• Delegated PluginSuite initialization outside RootDatabaseBuilder #6838 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[mkaput]

Reviewed 1 of 20 files at r1, all commit messages.
Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @integraledelebesgue and @orizi)

---

a discussion (no related file):
The number of changes here is tremendous to a level of alerting lights for me. Have you considered having a system of "use this plugin suite by default for crates if there are no per-crate ones"? This should make you avoid any added logic to tests

[integraledelebesgue]

Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)

---

a discussion (no related file):

Previously, mkaput (Marek Kaput) wrote…

The number of changes here is tremendous to a level of alerting lights for me. Have you considered having a system of "use this plugin suite by default for crates if there are no per-crate ones"? This should make you avoid any added logic to tests

Yeah, that would be useful in tests. This would require representing the default suite in the database and using it in the queries not being induced by Salsa's `inputs, all across the compiler. This sounds quite hacky to me. Also, it's relevant only in the context of testing so I haven't stuck with that idea.

[mkaput]

Reviewable status: 1 of 20 files reviewed, 1 unresolved discussion (waiting on @integraledelebesgue and @orizi)

---

a discussion (no related file):

Previously, integraledelebesgue (Jan Smółka) wrote…

Yeah, that would be useful in tests. This would require representing the default suite in the database and using it in the queries not being induced by Salsa's `inputs, all across the compiler. This sounds quite hacky to me. Also, it's relevant only in the context of testing so I haven't stuck with that idea.

it is acceptable to have such things dedicated for tests if it benefits them A LOT, and this one will do. For example, this will allow you to keep shared db

[integraledelebesgue]

Closing pull request: commit has gone away