Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preventing temporary segments generation for testing. #6641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preventing temporary segments generation for testing. #6641

wants to merge 1 commit into from

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 12, 2024 •
edited
Loading

This was referenced Nov 12, 2024
Open
Open
Open
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi changed the base branch from spr/main/a4fe6610 to main November 12, 2024 14:26
@orizi orizi changed the base branch from main to spr/main/b960baf9 November 12, 2024 14:26
@orizi orizi changed the base branch from spr/main/b960baf9 to main November 13, 2024 10:31
@orizi orizi mentioned this pull request Nov 13, 2024
Open
gilbens-starkware
gilbens-starkware approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orizi @reviewable-StarkWare @gilbens-starkware