Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Add a web3 erc20 example for StarknetJS #223

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

devnet0x
Copy link
Contributor

Also move previous starknet react examples under starknet-react title

@devnet0x
Copy link
Contributor Author

devnet0x commented Oct 18, 2023

Please your review @l-henri @omarespejel. Contribution to #194

@dalmasonto
Copy link
Contributor

Hello @devnet0x help solve prettier issue
Run the commands below before commiting

npm i
npm run format

@devnet0x
Copy link
Contributor Author

Done, please your review @dalmasonto thanks

@dalmasonto
Copy link
Contributor

Hello @devnet0x seems it didn't work, there are two files having some style problems, hope you did run npm run format

@devnet0x
Copy link
Contributor Author

Sorry @dalmasonto , please check again

@dalmasonto
Copy link
Contributor

Still you have same error, that is code style formatting error, that is why "all checks have failed" from above. I have made a quick fork of your repo and created a PR for the same devnet0x#1, I have formatted the docs their, just check it out, if your work is all there you can merge and see whether the above checks pass that is the prettier format checks

@devnet0x
Copy link
Contributor Author

done

@omarespejel
Copy link
Collaborator

Thanks, @devnet0x! Your updates are clear and I'm ready to merge them. Please address the conflict in the foundry forge chapter, as your well-formatted PR clashes with its previous state which was badly formatted.

Appreciate the review, @dalmasonto!

@devnet0x devnet0x reopened this Oct 23, 2023
@devnet0x
Copy link
Contributor Author

updated and now all check passed, please could you check @dalmasonto @omarespejel ?

@omarespejel omarespejel merged commit c8d9170 into starknet-edu:main Oct 25, 2023
2 checks passed
@omarespejel
Copy link
Collaborator

Hey @devnet0x, this is amazing! Thank you for pushing the subchapter! Also thanks for the reordering!

Thank you @dalmasonto for the review

imgbot bot pushed a commit to hardiktheprogrammer/starknetbook that referenced this pull request Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants