Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter remains visible when no cards are found #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aliraza556
Copy link
Contributor

Problem:

  • When a user adds multiple attributes with the same name, the indexes section displays duplicate index.

closes: #583

Issue ticket number and link:

Evidence:

https://www.loom.com/share/55bcc2bf7e8f47ea8091245eff4ebb78

image

Acceptance Criteria:

  • If no cards match the selected filter, the filter should remain visible.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome
  • Bug fix (non-breaking change which fixes an issue)
  • I have provided a screenshot of changes in my PR

@aliraza556
Copy link
Contributor Author

Hi @hritikmunde, Please review this PR.

@hritikmunde
Copy link
Contributor

@aliraza556 one of the checks is failing. Can you fix that?

@aliraza556
Copy link
Contributor Author

Hi @hritikmunde, the unit test has already failed due to this PR: #580. My code does not affect any unit tests.

@aliraza556
Copy link
Contributor Author

@hritikmunde, I noticed that the unit test logs don't show any failures, but I'm unsure why the test is marked as failed. I'll investigate the cause of the failure and resolve it.

image

@hritikmunde
Copy link
Contributor

@aliraza556 can you check the tests again?

@aliraza556
Copy link
Contributor Author

aliraza556 commented Oct 25, 2024

@aliraza556 can you check the tests again?

After merging this PR (#591), the unit test in this PR will be automatically fixed when I push the latest changes.

@aliraza556
Copy link
Contributor Author

@aliraza556 can you check the tests again?

Hi @hritikmunde, Please see here :

image

image

@aliraza556
Copy link
Contributor Author

@aliraza556 can you check the tests again?

Hi @hritikmunde, it doesn't matter if I push another commit because even if you make a PR without any changes, the unit test will still fail. This is because the unit test is taking too long—around 360 minutes, meaning it exceeds the expected time limit.

@hritikmunde
Copy link
Contributor

@aliraza556 that is quite long. What's the resolution? Can you minimize the time it takes as a test that long is not optimal and its gonna fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Filter disappears when no cards are found under Open, Paid, or Assigned
2 participants