-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter remains visible when no cards are found #590
base: master
Are you sure you want to change the base?
Conversation
Hi @hritikmunde, Please review this PR. |
@aliraza556 one of the checks is failing. Can you fix that? |
Hi @hritikmunde, the unit test has already failed due to this PR: #580. My code does not affect any unit tests. |
@hritikmunde, I noticed that the unit test logs don't show any failures, but I'm unsure why the test is marked as failed. I'll investigate the cause of the failure and resolve it. |
@aliraza556 can you check the tests again? |
After merging this PR (#591), the unit test in this PR will be automatically fixed when I push the latest changes. |
Hi @hritikmunde, Please see here : |
Hi @hritikmunde, it doesn't matter if I push another commit because even if you make a PR without any changes, the unit test will still fail. This is because the unit test is taking too long—around 360 minutes, meaning it exceeds the expected time limit. |
@aliraza556 that is quite long. What's the resolution? Can you minimize the time it takes as a test that long is not optimal and its gonna fail |
Problem:
closes: #583
Issue ticket number and link:
Open
,Paid
, orAssigned
#583 ]Evidence:
https://www.loom.com/share/55bcc2bf7e8f47ea8091245eff4ebb78
Acceptance Criteria:
Checklist before requesting a review