Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/search bot #556

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feat/search bot #556

wants to merge 10 commits into from

Conversation

tobi-bams
Copy link
Contributor

Search Bot

@tobi-bams tobi-bams linked an issue Jan 18, 2023 that may be closed by this pull request
Copy link
Contributor

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont like the hardcoded 3.95.131.14:5000. Put it in the config and make that value the default config. So you dont need to add it to the JSON file. BUT it can be changed if need be.

Also what is with the hardcoded macaroon string in there?

@tobi-bams
Copy link
Contributor Author

I dont like the hardcoded 3.95.131.14:5000. Put it in the config and make that value the default config. So you dont need to add it to the JSON file. BUT it can be changed if need be.

Also what is with the hardcoded macaroon string in there?

Ops!!....

So sorry this is just for test's sake, for the time being, I would add the 3.95.131.14:5000 to the config

Also for the hardcoded macaroon, we need that there just to be able to test

Copy link
Contributor

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks good

@kevkevinpal
Copy link
Contributor

just a heads up we can't call jarvis-backend directly we should do it through boltwall which asks for an lsat, that port 5000 will be closed as it is insecure to keep that open. If we intend to keep up a paywall

@@ -134,5 +135,6 @@ export function loadConfig() {
config.length_of_time_for_transport_token_clear ||
DEFAULT_LENGTH_DELAY_FOR_TRANSPORT_TOKEN_DB_CLEARING,
boltwall_server: config.boltwall_server || DEFAULT_BOLTWALL_SERVER,
private_graph: DEFAULT_PRIVATE_GRAPH,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so these private graphs should be set per tribe, but it seems like here we are just setting a single value in the config.

If I were to be in two different company tribes then this would not work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!!!.....

This won't work, when I raised that with Paul he said, for now, we are believing a user belongs to only one tribe.
After this, we would focus on other complex stuffs we want to factor in, such as what you just addressed

@kevkevinpal
Copy link
Contributor

kevkevinpal commented Feb 7, 2023

was merged in #593

was wrong disregard this comment :)

@kevkevinpal kevkevinpal closed this Feb 7, 2023
@tobi-bams tobi-bams mentioned this pull request Feb 7, 2023
@kevkevinpal kevkevinpal reopened this Feb 7, 2023
@tobi-bams tobi-bams linked an issue Feb 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relay graph subscription table Search bot
3 participants