Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version numbers from git tag and commit #97

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Nov 2, 2021

I added the version number and commit hash from git in the window title but it could also be added in the UI at the bottom for #87 .

When doing a release, all we need to do is add a proper tag in git (starting with v, like v0.8.1), update the version number in package.json and build from there to have version show automatically with hash. This matches github release suggested tagging practices.

Related to #51 .

Closes #67

@remyroy
Copy link
Member Author

remyroy commented Nov 2, 2021

This is how it looks when bundled
version-displayed
.

We also have access to BRANCH if we want to show the current branch name and LASTCOMMITDATETIME to show the last time there was a commit.

@remyroy
Copy link
Member Author

remyroy commented Nov 2, 2021

This makes the git latest tag the ultimate source of version number. We should still update version number in package.json but that one is only going to be used with electron-builder (for the final distribution file name for instance). I'm not sure if we can plug those together.

@remyroy remyroy requested a review from colfax23 November 2, 2021 19:52
@colfax23 colfax23 merged commit 3fe5456 into stake-house:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper versioning
2 participants