-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-27129: remove tenant-resources helm chart #2131
base: main
Are you sure you want to change the base?
Conversation
/retest |
/retest |
/retest |
1 similar comment
/retest |
@hector-vido: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test images |
/retest |
/retest |
8 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/test images |
/retest |
e203f73
to
88952ee
Compare
/retest |
88952ee
to
dc1e7d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -98,9 +98,6 @@ if [[ "$SPAWN_LOGGER" == "true" ]]; then | |||
fi | |||
|
|||
FAIL=0 | |||
if ! "${GITROOT}/.openshift-ci/tests/netpol-test.sh"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still need those tests? Are we going to move them to the gitops repository? How about creating a follow-up ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we still need them, but I can create a follow-up ticket.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Removing the tenant-resources helm chart.
This removes the logic branch where the reconciler could deploy the embedded
tenant-resources
helm chart, and assumes that ArgoCD is always enabled for tenants.Also, the
Network Policy Tests
were coupled to the oldtenant-resources
helm chart, and had to be deleted along with the chart.Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts