Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypicks 1.39 #51

Merged
merged 14 commits into from
Jul 3, 2024
Merged

cherrypicks 1.39 #51

merged 14 commits into from
Jul 3, 2024

Conversation

hown3d
Copy link

@hown3d hown3d commented Apr 5, 2024

drops 2 commits from previous release:

@hown3d hown3d force-pushed the cherrypicks-1.39 branch from fcf11cd to b1a55f2 Compare April 5, 2024 11:51
@maboehm
Copy link
Collaborator

maboehm commented Apr 5, 2024

arent most changes in provider stackit anyways? see some commits of https://github.com/stackitcloud/gardener-extension-provider-stackit/pull/106/commits

since controlplane is also part of stackit...
provider-openstack is essentially only used for workers right now.

@dergeberl
Copy link
Member

Please also add this changes: #52

@hown3d hown3d force-pushed the cherrypicks-1.39 branch from b1a55f2 to 1a7440e Compare April 11, 2024 08:41
@hown3d
Copy link
Author

hown3d commented Apr 11, 2024

Please also add this changes: #52

Needed some adjustments since the healthcheck code changed a bit when updating to 1.39

@hown3d
Copy link
Author

hown3d commented Apr 11, 2024

With the future merge of the openstack specific code e.g. (workers, cloudprovider webhook, healthcheck controller has worker parts and API packages) into the stackit provider it may not be neccessary to upgrade openstack to 1.39.

@nschad
Copy link

nschad commented Jun 17, 2024 •
edited
Loading

cherry-pick #56

@ske-prow ske-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2024
@MichaelEischer
Copy link
Collaborator

Please squash the fixup! Cherry-pick useExistingSubnet feature (10-01-2024) commit

MichaelEischer
MichaelEischer reviewed Jun 24, 2024
View reviewed changes
VERSION Outdated Show resolved Hide resolved
charts/gardener-extension-provider-openstack/HEAD Outdated Show resolved Hide resolved
@ske-prow ske-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2024
Kai Kummerer and others added 3 commits June 24, 2024 13:41
@Duciwuci
Cherry-pick useExistingSubnet feature (10-01-2024)
9982ba5 
add SubnetID to APIs (15bdb26)

implement 'use existing subnet' for terraform (8fac4ae)

implement 'use existing subnet' for infraflow (80f0836)

extend integration tests (3678da4)

extend infrastructureConfig validation (fa83256)

extend configValidator (547389c)
@maboehm @Duciwuci
Skip Loadbalancer Calls during deletion
3ae2541
@dergeberl @Duciwuci
Remove ControlPlane healthchecks (#52)
0b92e57
@Duciwuci Duciwuci force-pushed the cherrypicks-1.39 branch 2 times, most recently from d3b2ca7 to 0c85e1c Compare June 24, 2024 11:46
@Duciwuci
Copy link
Collaborator

@MichaelEischer thanks for feedback.

However, the pipeline is not working for this extension at version v1.39.

Therefore /hold

@Duciwuci Duciwuci added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@Duciwuci
Copy link
Collaborator

/kind enhancement
/kind upgrade

@ske-prow ske-prow bot added kind/enhancement Enhancement, improvement, extension kind/upgrade Upgrading components or dependencies (e.g., by renovate) labels Jun 24, 2024
@MichaelEischer
Copy link
Collaborator

@Duciwuci Fixing the build process should be possible by checking whether the script in the vendor folder still exists or switching to the new way to find the gardener path otherwise.

@Duciwuci Duciwuci force-pushed the cherrypicks-1.39 branch 2 times, most recently from b8cc902 to 1ecfb64 Compare June 24, 2024 12:01
@Duciwuci
Copy link
Collaborator

@Duciwuci Fixing the build process should be possible by checking whether the script in the vendor folder still exists or switching to the new way to find the gardener path otherwise.

I'm already on it. You will see a successful run in this PR soon.

maboehm and others added 2 commits June 24, 2024 14:07
@maboehm @Duciwuci
Use args in Deployment (#56)
e368ce4
@MichaelEischer @Duciwuci
Pass region to all openstack clients (#57)
ccf0998 
* create openstack clients with region

* extract region for remaining clients

* fix tests
@Duciwuci
Copy link
Collaborator

/hold cancel

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@MichaelEischer
Copy link
Collaborator

/lgtm

Judging from git range-diff ske-v1.38...cherrypicks-1.39 the cherry-pick is fine.

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@ske-prow
Copy link

ske-prow bot commented Jul 1, 2024

LGTM label has been added.

Git tree hash: c0447200a382d3abc698a1187be7825b0bcc17bc

@Duciwuci
Copy link
Collaborator

Duciwuci commented Jul 1, 2024

/hold waiting for provider-stackit lgtm

@ske-prow ske-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@Duciwuci
Copy link
Collaborator

Duciwuci commented Jul 3, 2024

/hold cancel

@ske-prow ske-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024
@Duciwuci
Copy link
Collaborator

Duciwuci commented Jul 3, 2024

/approve

@ske-prow ske-prow bot assigned nschad Jul 3, 2024
@nschad nschad added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@ske-prow
Copy link

ske-prow bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Duciwuci, nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot merged commit 5795f80 into ske-v1.39 Jul 3, 2024
9 checks passed
@ske-prow ske-prow bot deleted the cherrypicks-1.39 branch July 3, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duciwuci Duciwuci Duciwuci left review comments

@MichaelEischer MichaelEischer MichaelEischer left review comments

@nschad nschad nschad approved these changes

Assignees

@nschad nschad

@MichaelEischer MichaelEischer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension kind/upgrade Upgrading components or dependencies (e.g., by renovate) lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hown3d @maboehm @dergeberl @nschad @MichaelEischer @Duciwuci @einfachnuralex