Skip to content

Commit

Permalink
Skip Loadbalancer Calls during deletion
Browse files Browse the repository at this point in the history
  • Loading branch information
maboehm committed Jan 9, 2024
1 parent f74ea87 commit d4d5b28
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions pkg/controller/infrastructure/actuator_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,13 @@ func (a *actuator) deleteWithTerraformer(ctx context.Context, log logr.Logger, i
if err != nil {
return util.DetermineError(err, helper.KnownCodes)
}
loadbalancerClient, err := openstackClient.Loadbalancing()
if err != nil {
return util.DetermineError(err, helper.KnownCodes)
}

// STACKIT Openstack has no Loadbalancer API, so we are skipping this call, see
// https://github.com/gardener/gardener-extension-provider-openstack/issues/672
// loadbalancerClient, err := openstackClient.Loadbalancing()
// if err != nil {
// return util.DetermineError(err, helper.KnownCodes)
// }

stateInitializer := terraformer.StateConfigMapInitializerFunc(terraformer.CreateState)
tf = tf.InitializeWith(ctx, terraformer.DefaultInitializer(a.client, terraformFiles.Main, terraformFiles.Variables, terraformFiles.TFVars, stateInitializer)).SetEnvVars(internal.TerraformerEnvVars(infra.Spec.SecretRef, credentials)...)
Expand All @@ -134,7 +137,10 @@ func (a *actuator) deleteWithTerraformer(ctx context.Context, log logr.Logger, i
destroyKubernetesLoadbalancers = g.Add(flow.Task{
Name: "Destroying Kubernetes loadbalancers entries",
Fn: flow.TaskFn(func(ctx context.Context) error {
return a.cleanupKubernetesLoadbalancers(ctx, log, loadbalancerClient, vars[infrastructure.TerraformOutputKeySubnetID], infra.Namespace)
// STACKIT Openstack has no Loadbalancer API, so we are skipping this call, see
// https://github.com/gardener/gardener-extension-provider-openstack/issues/672
// return a.cleanupKubernetesLoadbalancers(ctx, log, loadbalancerClient, vars[infrastructure.TerraformOutputKeySubnetID], infra.Namespace)
return nil
}).
RetryUntilTimeout(10*time.Second, 5*time.Minute).
DoIf(configExists),
Expand Down

0 comments on commit d4d5b28

Please sign in to comment.