Remove prevent_destroy from branch protection rules

Using prevent_destroy prevents moving repositories between teams. Although branch protections are sensitive, we won't lose any data by simply removing them.
stackhpc · Dec 20, 2023 · 441742a · 441742a
1 parent adade3f
commit 441742a
Showing 1 changed file with 0 additions and 35 deletions.
diff --git a/terraform/github/branches.tf b/terraform/github/branches.tf
@@ -26,10 +26,6 @@ resource "github_branch_protection" "ansible_branch_protection" {
     contexts = lookup(var.required_status_checks, each.key, { "default" : [] }).default
     strict   = false
   }
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }
 
 resource "github_branch_protection" "batch_branch_protection" {
@@ -55,10 +51,6 @@ resource "github_branch_protection" "batch_branch_protection" {
     contexts = lookup(var.required_status_checks, each.key, { "default" : [] }).default
     strict   = false
   }
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }
 
 resource "github_branch_protection" "kayobe_branch_protection_py_3-6" {
@@ -94,10 +86,6 @@ resource "github_branch_protection" "kayobe_branch_protection_py_3-6" {
     }).default)
     strict = false
   }
-
-  lifecycle {
-    prevent_destroy = false
-  }
 }
 
 resource "github_branch_protection" "kayobe_branch_protection_py_3-10" {
@@ -129,10 +117,6 @@ resource "github_branch_protection" "kayobe_branch_protection_py_3-10" {
     }).default)
     strict = false
   }
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }
 
 resource "github_branch_protection" "openstack_branch_protection_py_3-6" {
@@ -168,9 +152,6 @@ resource "github_branch_protection" "openstack_branch_protection_py_3-6" {
     }).default)
     strict = false
   }
-  lifecycle {
-    prevent_destroy = true
-  }
 }
 
 resource "github_branch_protection" "openstack_branch_protection_py_3-10" {
@@ -202,10 +183,6 @@ resource "github_branch_protection" "openstack_branch_protection_py_3-10" {
     }).default)
     strict = false
   }
-
-  lifecycle {
-    prevent_destroy = false
-  }
 }
 
 resource "github_branch_protection" "platform_branch_protection" {
@@ -231,10 +208,6 @@ resource "github_branch_protection" "platform_branch_protection" {
     contexts = lookup(var.required_status_checks, each.key, { "default" : [] }).default
     strict   = false
   }
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }
 
 resource "github_branch_protection" "releasetrain_branch_protection" {
@@ -260,10 +233,6 @@ resource "github_branch_protection" "releasetrain_branch_protection" {
     contexts = lookup(var.required_status_checks, each.key, { "default" : [] }).default
     strict   = false
   }
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }
 
 resource "github_branch_protection" "smslab_branch_protection" {
@@ -289,9 +258,5 @@ resource "github_branch_protection" "smslab_branch_protection" {
     contexts = lookup(var.required_status_checks, each.key, { "default" : [] }).default
     strict   = false
   }
-
-  lifecycle {
-    prevent_destroy = true
-  }
 }