add logout #3
Open
add logout #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougszumski
requested changes
Jan 6, 2025
collector/redfish_collector.go
Outdated
| @@ -99,6 +99,8 @@ func (r *RedfishCollector) Collect(ch chan<- prometheus.Metric) { | |||
|
|
|||
| ch <- r.redfishUp | |||
| ch <- prometheus.MustNewConstMetric(totalScrapeDurationDesc, prometheus.GaugeValue, time.Since(scrapeTime).Seconds()) | |||
| defer r.redfishClient.Logout() | |||
There was a problem hiding this comment.
Hmm, the logout on line 84 should handle the session close. I hadn't seen that.
We can't do it on line 102 because r.redfishClient could be nil.
It does appear that we hit the else branch in practise. I see redfish_up = 0 in historical data, and around those times we see dropouts in other data. We need to get to bottom of why that happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.