Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slurm config in prod2312 branch #18

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Feb 1, 2024

  • Using Enable use of custom Slurm builds ansible-role-openhpc#163 means openhpc_slurmd_spool_dir has to be specified instead of openhpc_config_extra.SlurmdSpoolDir, so that the role can actually create the spool dir.
  • The openhpc_config_extra dict is defined both environments/nrel/inventory/group_vars/openhpc/overrides and in environments/{prod,vtest}/inventory/group_vars/all/openhpc-generic-slurm.yml, which makes it unclear which one is actually getting applied.
  • environments/nrel/inventory/group_vars/openhpc/overrides.yml defines openhpc_config_extra.StateSaveLocation - this should be defined using openhpc_state_save_location. NB the set location /var/spool/slurm/slurmctld is not on persistent storage, not addressed here.
  • Some general tidying of openhpc_* vars so that these are only contained in 3x files: environments/{nrel,vtest,prod}/group_vars/openhpc/overrides.yml

Not addressed by this PR: openhpc_packages_extra_nrel (used by) openhpc_packages_extra won't be applied here, when using generic slurm, openhpc_generic_packages is used instead. It also contains a lot of openhpc-specific packages.

@sjpb sjpb changed the base branch from nrel to prod2312 February 1, 2024 16:41
@sjpb sjpb mentioned this pull request Feb 1, 2024
5 tasks
@sjpb sjpb marked this pull request as draft February 1, 2024 16:42
@sjpb sjpb marked this pull request as ready for review February 1, 2024 17:06
@sjpb sjpb changed the title Prod2312 fix slurmconf Fix Slurm config in prod2312 branch Feb 1, 2024
@sjpb sjpb merged commit 008ac32 into prod2312 Feb 2, 2024
@sjpb sjpb deleted the prod2312-fix-slurmconf branch July 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant