Synchronise 2024.1 with upstream #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The variable kolla_same_external_internal_vip in group_vars/all.yml was set to true or false depending on the jinja2 equality operator - == - which only checks if two objects are the same. This is problematic because IPs can be the same but have different string representations, e.g. leading zeroes in some octets, but still repesent the same instance of an IP. Example: 192.168.1.1 and 192.168.001.001 are the same. Fix this, by using the ansible.utils.ipaddr() jinja2 filter instead to increase robustness. Closes-Bug: #2076889 Introduced-By: https://review.opendev.org/c/openstack/kolla/+/285005 Signed-off-by: Sven Kieske <[email protected]> Change-Id: Ied43b9d0c4b33bb514d367f3f99c2e30e104d139 (cherry picked from commit a5f0e16)
priteau
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2024.1 from upstream stable/2024.1.