Synchronise 2024.1 with upstream #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This patch removes the nova_libvirt_secret container volume because it is a complete antipattern, and during testing, I found that it causes problems. When it was necessary to copy libvirt secrets from /etc/kolla/nova-libvirt/secrets, the container logs reported that the resource is busy - precisely because it was a mounted container volume. This, of course, is unnecessary because the secrets are copied to the kolla host in /etc/kolla/nova-libvirt/secrets. Closes-Bug: #2073678 Change-Id: I715a6a95f9d32d62a8199727ddbaddd0dd7baa2d (cherry picked from commit 82a642e)
It can be useful to run Ironic commands on the public API if access to the internal API is not possible. Related-Bug: #2051837 Change-Id: Ice0eb62f2bb26ca6e3ac8d02c6ea787b60408a86 (cherry picked from commit 1916b3c)
Add global_request_id according to oslo.log defaults [1], also support lines like: 2024-12-23 20:48:29.905 2 ERROR oslo_service.periodic_task ['Traceback (most recent call last):\\n' [1]: https://docs.openstack.org/oslo.log/latest/configuration/#DEFAULT.logging_context_format_string Closes-Bug: #2044370 Change-Id: I80c3e20de0b7503de6331b55879e85892323b3d6 (cherry picked from commit 5a3fb2b)
mnasiadka
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2024.1 from upstream stable/2024.1.