Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.1: Backport Add support for customising Neutron physical network names #315

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

markgoddard
Copy link

@markgoddard markgoddard commented Aug 6, 2024

Backported from upstream open review https://review.opendev.org/c/openstack/kayobe/+/922335

Used in 2 deployments.

Previously Kolla Ansible hard-coded Neutron physical networks starting
at physnet1 up to physnetN, matching the number of interfaces in
neutron_external_interface and bridges in neutron_bridge_name.

Sometimes we may want to customise the physical network names used.
This may be to allow for not all hosts having access to all physical
networks, or to use more descriptive names.

For example, in an environment with a separate physical network for
Ironic provisioning, controllers might have access to two physical
networks, while compute nodes have access to one.

This change extends the 'physical_network' network attribute to make it
possible to customise the Neutron physical network names used for the
OVS, OVN, Linux bridge and OVS DPDK plugins. The default behaviour is
unchanged.

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922320
Change-Id: I214444c60653f484fcda6275cc725879d14f9e7a

@markgoddard markgoddard requested a review from a team as a code owner August 6, 2024 13:54
@markgoddard markgoddard self-assigned this Aug 6, 2024
@markgoddard markgoddard changed the title Add support for customising Neutron physical network names 2023.1: Backport Add support for customising Neutron physical network names Aug 6, 2024
Previously Kolla Ansible hard-coded Neutron physical networks starting
at physnet1 up to physnetN, matching the number of interfaces in
neutron_external_interface and bridges in neutron_bridge_name.

Sometimes we may want to customise the physical network names used.
This may be to allow for not all hosts having access to all physical
networks, or to use more descriptive names.

For example, in an environment with a separate physical network for
Ironic provisioning, controllers might have access to two physical
networks, while compute nodes have access to one.

This change extends the 'physical_network' network attribute to make it
possible to customise the Neutron physical network names used for the
OVS, OVN, Linux bridge and OVS DPDK plugins. The default behaviour is
unchanged.

Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/922320
Change-Id: I214444c60653f484fcda6275cc725879d14f9e7a
(cherry picked from commit 16879753261109defdf41cd9151d70fc22c5a306)
@markgoddard markgoddard force-pushed the 2023.1-backport-physnets branch from 7e8ee1d to c1da665 Compare August 6, 2024 14:41
Copy link

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this has been tested at customer deployments, I think it is reasonable to merge even if this hasn't yet landed upstream.

@markgoddard markgoddard merged commit 5c4eb5e into stackhpc/2023.1 Aug 7, 2024
3 checks passed
@markgoddard markgoddard deleted the 2023.1-backport-physnets branch August 7, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants