fix!: remove extra argument from redact_config_dir call #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered an issue whereby config-diff was reporting changes to various files not replaced to the PR in question. Changes included vaulted files like Ceph keyrings but also contents of passwords.yml like rabbitmq-key.The change proposed wasd41d8cd98f00b204e9800998ecf8427eacross various files which is the MD5 of an empty string.The problem is not consistent and doesn't occur very often and when it does the files it impacts varries each time.An unproven theory is that due to the combination of parallel config, automatic secret discovery and the incorrect extra argument$target_kayobe_config_dirin redact_config_dir call means that sometimes it MD5 files that don't exist due to https://github.com/stackhpc/kayobe-automation/blob/main/scripts/config-diff.sh#L120The above problem hasn't been fixed with this PR. MD5 hash of empty files are still happening.
Regardless this extra argument is unwanted and should be removed.