Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally ignore image changes in TF #545

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Jan 22, 2025

When a compute group has the ignore_image_changes parameter set to true, changes to the image_id parameter (which defaults to cluster_image_id) are ignored by OpenTofu.

Regardless of whether ignore_image_changes is set, OpenTofu templates out the image_id into the Ansible inventory for each compute node. The compute_init role templates out hostvars to the control node, which means the "target" image ID is then available on the control node. Subsequent work will use this to rebuild the node via slurm.

@bertiethorpe bertiethorpe requested a review from a team as a code owner January 22, 2025 10:28
@bertiethorpe bertiethorpe requested a review from sjpb January 22, 2025 10:53
docs/experimental/compute-init.md Outdated Show resolved Hide resolved
docs/experimental/compute-init.md Outdated Show resolved Hide resolved
docs/experimental/compute-init.md Outdated Show resolved Hide resolved
docs/experimental/compute-init.md Outdated Show resolved Hide resolved
docs/experimental/compute-init.md Outdated Show resolved Hide resolved
docs/experimental/compute-init.md Outdated Show resolved Hide resolved
@bertiethorpe bertiethorpe requested a review from sjpb January 22, 2025 11:37
@sjpb sjpb changed the title Ignore image changes to TF state; toggle via main.tf Optionally ignore image changes in TF Jan 22, 2025
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny tweak to variable description

@sjpb sjpb self-requested a review January 22, 2025 14:24
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 40665c0 into main Jan 22, 2025
2 checks passed
@sjpb sjpb deleted the feat/compute-init-cluster-image branch January 22, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants