-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally ignore image changes in TF #545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpb
requested changes
Jan 22, 2025
environments/skeleton/{{cookiecutter.environment}}/tofu/compute/nodes.tf
Outdated
Show resolved
Hide resolved
environments/skeleton/{{cookiecutter.environment}}/tofu/compute/variables.tf
Outdated
Show resolved
Hide resolved
sjpb
changed the title
Ignore image changes to TF state; toggle via main.tf
Optionally ignore image changes in TF
Jan 22, 2025
sjpb
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny tweak to variable description
environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
Outdated
Show resolved
Hide resolved
…les.tf Co-authored-by: Steve Brasier <[email protected]>
sjpb
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a compute group has the
ignore_image_changes
parameter set to true, changes to theimage_id
parameter (which defaults tocluster_image_id
) are ignored by OpenTofu.Regardless of whether
ignore_image_changes
is set, OpenTofu templates out theimage_id
into the Ansible inventory for each compute node. Thecompute_init
role templates out hostvars to the control node, which means the "target" image ID is then available on the control node. Subsequent work will use this to rebuild the node via slurm.