Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume_backed_instances not working for compute nodes #527

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix volume_backed_instances not working for compute nodes #527

merged 1 commit into from
Jan 9, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 9, 2025

Relevant variables were not passed in to compute module.

Tested:

  • setting volume_backed_instances and root_volume_size just for one compute group
  • setting volume_backed_instances at top-level and non-default root_volume_size for one compute group

Note CI does not test this so can be merged without that passing.

@sjpb sjpb requested a review from a team as a code owner January 9, 2025 10:14
wtripp180901
wtripp180901 previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb force-pushed the fix/vol-backed-compute branch from a545bd0 to 2c278e0 Compare January 9, 2025 10:45
@sjpb sjpb requested a review from wtripp180901 January 9, 2025 10:45
wtripp180901
wtripp180901 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 6929272 into main Jan 9, 2025
1 of 2 checks passed
@sjpb sjpb deleted the fix/vol-backed-compute branch January 9, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtripp180901 wtripp180901 wtripp180901 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @wtripp180901