Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Release Train OpenHPC repos #515

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Add Release Train OpenHPC repos #515

merged 8 commits into from
Jan 7, 2025

Conversation

wtripp180901
Copy link
Contributor

@wtripp180901 wtripp180901 commented Jan 3, 2025 •
edited
Loading

@wtripp180901 wtripp180901 requested a review from a team as a code owner January 3, 2025 13:41
@wtripp180901
Copy link
Contributor Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12598630413

@wtripp180901 wtripp180901 requested a review from sjpb January 3, 2025 16:45
sjpb
sjpb requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for clarity, one thing I think is a logic problem?

ansible/roles/dnf_repos/defaults/main.yml Outdated Show resolved Hide resolved
environments/common/inventory/group_vars/all/openhpc.yml Outdated Show resolved Hide resolved
@wtripp180901
Copy link
Contributor Author

https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12629768506

@wtripp180901 wtripp180901 requested a review from sjpb January 6, 2025 09:56
@wtripp180901 wtripp180901 requested a review from sjpb January 7, 2025 09:06
sjpb
sjpb approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 4def5ba into main Jan 7, 2025
0 of 6 checks passed
@sjpb sjpb deleted the feat/ohpc-release-train branch January 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtripp180901 @sjpb