Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volume mounting robust #333

Closed
wants to merge 3 commits into from
Closed

Make volume mounting robust #333

wants to merge 3 commits into from

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Nov 29, 2023

Use the OpenStack volume ID to find the appropriate block device when labeling filesystem volumes.

Previously labeling relied on the ordering in /dev matching the order of the block device definitions in the terraform instance resource. This was the case for RockyLinux 8.8 images but does not appear to be the case for RockyLinux 8.9 images.

Notes:

  • The filesystem volume label is taken from the first word of the OpenStack volume description.
  • cloud-init's runcmd happens after mounts, so bootcmd must be used to create filesystems.
  • The mount options used are the cloud-init mount module's defaults, except that nofail is not specified to avoid hard-to-diagnose problems and the home volume mount declares it is required by the NFS server.
  • If the image has hw_disk_bus='scsi' and hw_scsi_model='virtio-scsi' properties set, entries in /dev/disk-by-id contain the full openstack volume ID (plus a prefix). Without these properties, the entries only contain the first 20 characters of the openstack volume ID.

Fixes #327

TODO:

@sjpb sjpb mentioned this pull request Nov 29, 2023
1 task
@sjpb
Copy link
Collaborator Author

sjpb commented Dec 8, 2023

Replaced by #341

@sjpb sjpb closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should fix dependency on volume order
1 participant