Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify upper constraints to 2023.1 Antelope #21

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

markgoddard
Copy link

This provides openstacksdk > 1.0, which is required for openstack.cloud modules.

This provides openstacksdk > 1.0, which is required for openstack.cloud modules.
@markgoddard markgoddard requested a review from a team as a code owner November 30, 2023 10:33
@markgoddard markgoddard self-assigned this Nov 30, 2023
@markgoddard markgoddard requested a review from scrungus November 30, 2023 10:33
Copy link
Contributor

@scrungus scrungus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like os_volumes should also have an upper constraints file, although it currently doesn't :

dependencies:
- role: stackhpc.openstack.os_openstacksdk
os_openstacksdk_venv: "{{ os_volumes_venv }}"
- role: stackhpc.openstack.os_openstackclient
os_openstackclient_venv: "{{ os_volumes_venv }}"

as it uses openstack.cloud.volume module

@markgoddard
Copy link
Author

It looks like os_volumes should also have an upper constraints file, although it currently doesn't :

dependencies:
- role: stackhpc.openstack.os_openstacksdk
os_openstacksdk_venv: "{{ os_volumes_venv }}"
- role: stackhpc.openstack.os_openstackclient
os_openstackclient_venv: "{{ os_volumes_venv }}"

as it uses openstack.cloud.volume module

Done

Copy link
Contributor

@scrungus scrungus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that, otherwise LGTM

roles/os_volumes/defaults/main.yml Outdated Show resolved Hide resolved
@markgoddard markgoddard merged commit b77ddc2 into main Dec 1, 2023
4 checks passed
@markgoddard markgoddard deleted the 2023.1-upper-constraints branch December 1, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants