os_images role #43
scrunguslint-collection.yml
on: pull_request
Matrix: lint / lint
Matrix: lint / sanity
Annotations
12 errors and 6 warnings
|
yaml[comments]:
roles/os_images/defaults/main.yml#L61
Missing starting space in comment
|
|
schema[meta]:
roles/os_images/meta/main.yml#L1
$.galaxy_info.min_ansible_version 2.0 is not of type 'string'. See https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_reuse_roles.html#using-role-dependencies
|
|
yaml[comments]:
roles/os_images/meta/main.yml#L3
Missing starting space in comment
|
|
fqcn[action-core]:
roles/os_images/tasks/images.yml#L2
Use FQCN for builtin module actions (include_vars).
|
|
fqcn[action-core]:
roles/os_images/tasks/images.yml#L5
Use FQCN for builtin module actions (package).
|
|
fqcn[action-core]:
roles/os_images/tasks/images.yml#L12
Use FQCN for builtin module actions (package).
|
|
fqcn[action-core]:
roles/os_images/tasks/images.yml#L24
Use FQCN for builtin module actions (file).
|
|
risky-file-permissions:
roles/os_images/tasks/images.yml#L24
File permissions unset or incorrect.
|
|
fqcn[action-core]:
roles/os_images/tasks/images.yml#L32
Use FQCN for builtin module actions (file).
|
|
fqcn[action-core]:
roles/os_images/tasks/images.yml#L42
Use FQCN for builtin module actions (file).
|
|
lint / Ansible 2.12 lint:
roles/os_images/tasks/images.yml#L24
risky-file-permissions File permissions unset or incorrect
|
|
lint / Ansible 2.12 lint:
roles/os_images/tasks/images.yml#L42
risky-file-permissions File permissions unset or incorrect
|
|
jinja[spacing]:
roles/os_images/defaults/main.yml#L24
Jinja2 spacing could be improved: {{ lookup('env','HOME') }}/disk_images -> {{ lookup('env', 'HOME') }}/disk_images
|
|
jinja[spacing]:
roles/os_images/tasks/images.yml#L110
Jinja2 spacing could be improved: {% if item.size is defined %}--image-size {{ item.size }}{% endif %} {% if item.type is defined %}-t {{ item.type }}{% endif %} {% if item.packages | default %}-p {{ item.packages | join(',') }}{% endif %} {{ os_images_common }} {{ item.elements | join( ' ' ) }} -o {{ item.name }} -> {% if item.size is defined %}--image-size {{ item.size }}{% endif %} {% if item.type is defined %}-t {{ item.type }}{% endif %} {% if item.packages | default %}-p {{ item.packages | join(',') }}{% endif %} {{ os_images_common }} {{ item.elements | join(' ') }} -o {{ item.name }}
|
|
jinja[spacing]:
roles/os_images/tasks/promote.yml#L19
Jinja2 spacing could be improved: The image {{ item.name[:-(os_images_name_suffix | length | int)] }} does not exist. -> The image {{ item.name[: -(os_images_name_suffix | length | int)] }} does not exist.
|
|
jinja[spacing]:
roles/os_images/tasks/promote.yml#L46
Jinja2 spacing could be improved: {{ item.name[:-(os_images_name_suffix | length | int)] }} -> {{ item.name[: -(os_images_name_suffix | length | int)] }}
|
|
jinja[spacing]:
roles/os_images/tasks/promote.yml#L53
Jinja2 spacing could be improved: {{ item.name[:-(os_images_name_suffix | length | int)] }} -> {{ item.name[: -(os_images_name_suffix | length | int)] }}
|
|
jinja[spacing]:
roles/os_images/tasks/promote.yml#L62
Jinja2 spacing could be improved: {{ item.name[:-(os_images_name_suffix | length | int)] }} -> {{ item.name[: -(os_images_name_suffix | length | int)] }}
|