Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce role for service specs #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tomclark0
Copy link

This role provides a mechanism to write arbitrary service definitions that can be freely applied.

Currently introducing arbitrary services can be performed by using the cephadm_osd_spec and defining an alternative service_type.
Some options are not exposed with cephadm commands.

Providing a seperate role for service definitions avoids defining services with cephadm_osd_spec.

Wanted feedback if this approach is valid.

Note - There can be issues when defining both an arbitrary service and accompanying ingress service. The ingress service is defined before the backend.

If this approach is valid, then the cephadm_ingress_services role could be refactored to support the re-ordering of tasks.

@tomclark0 tomclark0 marked this pull request as ready for review January 10, 2025 12:53
@tomclark0 tomclark0 requested a review from a team as a code owner January 10, 2025 12:53
@mnasiadka
Copy link
Member

I think we'd need some discussion to lay out some plan - either we're having a role per each ,,spec group'' (e.g. osd specs, ingress specs, etc) - which doesn't sound like a good idea.
I think I'd be more inclined to go with a universal role - that would cover all sorts of specs - OSD, RGW, Ingress, NFS, whatnot - and rather have them defined in a way like we define RGW spec in cephadm role - e.g. cephadm_radosgw_services
@jackhodgkiss @cityofships ideas? comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants