Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This role provides a mechanism to write arbitrary service definitions that can be freely applied.
Currently introducing arbitrary services can be performed by using the
cephadm_osd_spec
and defining an alternativeservice_type
.Some options are not exposed with cephadm commands.
Providing a seperate role for service definitions avoids defining services with
cephadm_osd_spec
.Wanted feedback if this approach is valid.
Note - There can be issues when defining both an arbitrary service and accompanying ingress service. The ingress service is defined before the backend.
If this approach is valid, then the
cephadm_ingress_services
role could be refactored to support the re-ordering of tasks.