Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some redundant GL validation. #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

null77
Copy link

@null77 null77 commented Jan 14, 2025

ANGLE itself can manage most of WebGL validation. This makes the transition to WebGL 2 validation easier because we won't need to write new logic for all the new entry points.

To this effect this enables robust memory features in ANGLE, and also updates the error set logic.

This contribution is funded by http://higharc.com/

@dhritzkiv this is the next functional change. Still passes all tests with the updated gl-conformance for me locally on Windows.

@null77 null77 force-pushed the remove-extra-validation branch from 03ff51d to 4fba562 Compare January 14, 2025 18:53
@null77
Copy link
Author

null77 commented Jan 14, 2025

Added a new push which removes some extra texture validation, helper functions, and validation in draw calls.

ANGLE itself can manage most of WebGL validation. This makes the
transition to WebGL 2 validation easier because we won't need to write
new logic for all the new entry points.

To this effect this enables robust memory features in ANGLE, and also
updates the error set logic.

This contribution is funded by http://higharc.com/
@null77 null77 force-pushed the remove-extra-validation branch from 4fba562 to df9d965 Compare January 14, 2025 19:31
@null77
Copy link
Author

null77 commented Jan 14, 2025

Another small update with some extra validation removed for ANGLE_instanced_arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant