fix: WebLN QR fallback for anon users #1858
Open
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soxasora
force-pushed
the
anon_webln_qr_fallback
branch
from
89da4b4 to
53f63c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1758
When a WebLN wallet request fails (eg. cancelling a transaction) it can't be re-requested until next reload, throwing an error and prompting an invoice retry with QR that fails if the user is not logged in.
This fix throws a "cannot re-enable wallet"
WalletError, used to bypass retryPaidAction and to show a QR payment with the same invoice.Screenshots
Screen.Recording.2025-02-03.at.11.50.58.mov
Additional Context
Fix specifically applied for WebLN
Checklist
Are your changes backwards compatible? Please answer below:
Yes, only affects WebLN wallet
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, more testing
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
No