Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor of vanilla js file #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arpit1993
Copy link

@Arpit1993 Arpit1993 commented Dec 1, 2023

Description

Updated the Vanilla Js file

Changes Made

Refactored the code a bit.

Screenshots (if applicable)

Not Applicable

Checklist

  • I have tested these changes locally and they work as expected.
  • I have updated the README if necessary.

Related Issues

Not Applicable

Deployment Notes

Not Applicable

@sanchezfdezjavier
Copy link
Contributor

Hello @Arpit1993, thanks for contributing! Is there any issue/missing feature this PR is addressing?

@sanchezfdezjavier sanchezfdezjavier requested a review from a team December 4, 2023 10:46
@Arpit1993
Copy link
Author

Hi sanchezfdezjavier, I've actually refactored the code to leverage the ES6 features of JavaScript. No big changes made yet to the logic part. Thanks.

@sanchezfdezjavier
Copy link
Contributor

Refactored the code a bit.

Would you mind if I ask you how did you end up creating this PR? Are you a user of the package? Would love to hear your feedback!

@Arpit1993
Copy link
Author

Hi sanchezfdezjavier, I forked the repository to my account. Tried things locally and then made the changes and raised a PR.

Refactored the code a bit.

Would you mind if I ask you how did you end up creating this PR? Are you a user of the package? Would love to hear your feedback!

@sanchezfdezjavier
Copy link
Contributor

Hi sanchezfdezjavier, I forked the repository to my account. Tried things locally and then made the changes and raised a PR.

Refactored the code a bit.

Would you mind if I ask you how did you end up creating this PR? Are you a user of the package? Would love to hear your feedback!

Sorry, I've miss-explained myself, I mean what's the reason behind the change? Do you use the package in your website? How did you find the repo, this is more like a user-feedback question 😁

Copy link
Contributor

@sanchezfdezjavier sanchezfdezjavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants