-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding free-text extension. #655
Adding free-text extension. #655
Conversation
@m-mohr Could I get your opinion on this I know you've helped with the extension definition. |
stac_fastapi/extensions/stac_fastapi/extensions/third_party/free_text/free_text.py
Outdated
Show resolved
Hide resolved
where are we with this PR? @rhysrevans3 |
We're unsure on if basic and advanced search are compatible stac-api-extensions/freetext-search#10 I think the current options are, update the advanced search to better match with the basic search or separate them into two extensions. |
Dear @rhysrevans3 and @m-mohr I've refactored a bit this extension to:
|
Correct for Advanced, not for Basic. See also stac-api-extensions/freetext-search#11 |
I guess I'm going to create 2 Extensions to make this a bit more clear |
That's a very good idea, especially as they are not quite compliant yet. |
There is a draft pr in sfeos related to this but I don't think it gives any new information - https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/227/files |
This is ready for review It would be nice to add documentation but this can be done in another PR ;-) |
Was the implementation tested against STAC Browser by any chance? |
no, but I don't know any backend supporting the free-text spec 😓 |
@m-mohr I don't really see how the free-text extension is used by STAC-Browser maybe https://github.com/radiantearth/stac-browser/blob/108947ebe8cbd64c7e288bbaa3c5f81293706d3e/src/components/SearchFilter.vue#L141 seems to point that |
I'm going to merge this PR (so I can continue on the collection-search which depends on the free-text ext) but feel free to comment and we could still make changes before we do a next release |
**Description:** Adding the free-text search extension. Related to stac-utils/stac-fastapi#655 **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [x] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog
Related Issue(s):
Description:
Adding the free-text extension
PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)