-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extension to 'candidate' maturity level #37
base: main
Are you sure you want to change the base?
Conversation
Are there 3 implementations and no planned breaking changes in the issue tracker? :) I was surprised by how extensive the documentation is now 👌 |
There's one issue being discussed that could include a breaking change, #31, if we remove torch.compile as an artifact_type option and instead introduce a new jit_compiled field. Following the Candidate guidelines, this would require a new version. This isn't planned/decided yet, going to discuss this and some other issues with Francis when we meet up next week at SigSpatial.
given that we would increment the version if there was a breaking change and have been following this practice for awhile after the 1.0.0 version I think Candidate makes sense. |
Good point @m-mohr |
Not necessarily all issues, but if breaking changes are in the pipeline, we usually hold the extension maturity back for a bit. |
The above issues are now addressed. no breaking changes are planned. I think we can update the maturity level now? |
We should have a |
Description
Given the number of participants in the paper, and the actual publishing of the paper, we can consider the extension is a fairly stable state.
As per Extension Maturity, it is time to move it to
Candidate
.Related Issue
Type of Change
Checklist
CONTRIBUTING.md
guide;make check
;Google
format for all the methods and classes that I used.