generated from obsidianmd/obsidian-sample-plugin
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sidebar note display #1060
Closed
Newdea
wants to merge
15
commits into
st3v3nmw:master
from
open-spaced-repetition:fix/sidebarNoteDisplay
Closed
fix sidebar note display #1060
Newdea
wants to merge
15
commits into
st3v3nmw:master
from
open-spaced-repetition:fix/sidebarNoteDisplay
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @Newdea, I've tried google translating open-spaced-repetition#76 but I still don't understand what the issue is. Could you please provide some more details? |
st3v3nmw
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I see what the issue is. Please check the merge conflict, I can't fix it through the UI.
Thanks.
…3nmw#1051) * Fixed: Completed updating references to folder docs to docs/docs * Restored new line
* Fixed * Format & lint
* Update tr.ts First translate 100% * Update tr.ts Quotation marks edit * Update tr.ts pnpm run format
…menu options (st3v3nmw#1066) * Added options in the settings to hide icon and status bar. * - Enabled the possibility to disable file menu options without restarting Obsidian or reloading the plugin. - Changed the phrasing for the user from `Disable` to `Enable` to make it easier to understand and aligned with the other options. * Adjusted the translation in the different languages. * removing unnecessary logs * Fixed bug st3v3nmw#1072
* Full coverage for UnitTest utils * Change test config * Added Unit Test for stats * Added Unit Test for NumberCountDict * Add function parseDateToTicks, formatDate * Fix includes and doc * Added Testcases * Remove unused function * Try fix ticksFromDate * Fix lint * [FIX] isEqualOrSubPath function (st3v3nmw#1048) * Improve isEqualOrSubPath Description + remove use of normalize * update changelog * fix linting * update changelog * Revert "update changelog" This reverts commit d7ba801. * Update Changelog * feat: refactor code to support diff methods of storing the scheduling info, and diff SR algorithms (st3v3nmw#1006) * Perhaps half way towards implementation; doesn't build yet * Implemented 70%; doesn't build * Progress * Progress * Progress * 11 of the 19 existing test suites pass * 12 of the 19 existing test suites pass * 14 of the 19 existing test suites pass * Progress * 15 of the 19 existing test suites pass * All nineteen existing test suites pass * Minor fixes * More refactoring; doesn't build * Progress, doesn't build * Builds and all existing unit tests pass * Progress * Merge remote-tracking branch 'upstream/master'; due to conflicts fair manual work involved to complete merge with unit test cases working * Continued fixing post st3v3nmw#495 integration * Added some test cases for OsrCore * Added unit test support code * Added more test files * Added test case, fixed code issues * Updated tests * Small refactor * !!GitHub_Desktop<feat-878-support-multiple-schedule-methods> * Fixes post merge stash * Added tests * More refactoring * Improved test coverage * Improved unit test code coverage * Starting testing of plugin within Obsidian * Bug fixes * Fixed broken test cases * Added test case for global coverage * A few merge fixes * Version ready for beta testing * Format and lint * Updated actions/checkout@v3 to node 20 * Lets make lint happy! * Previously the pnpm format added a blank line in a test markdown file which caused the test to fail * Slightly reduced jest code coverage threshold to writing a number of difficult test cases * Fixed bug where note frontmatter interval/ease set to null (app specific code, not core code) * Fixed some note review queue bugs (previously introduced in branch st3v3nmw#878) * Lint & format * Fixed bug preventing stats being shown (previously introduced in branch st3v3nmw#878) * Squashed commit of the following: commit 3228e9c Author: Ronny Zulaikha <[email protected]> Date: Wed Jul 24 15:10:39 2024 +1000 Support RTL flashcards specified by frontmatter "direction" attribute (st3v3nmw#935) * Nearly completed * Added RTL support for flashcards edit modal * Changes as part of the merge * post upstream master merge fixes * Minor code improvement * lint and format * Change log and documentation update * Minor code change * Fixed EditModal RTL * lint and format * Updated test cases to fix global coverage error * Format & lint commit 971e4af Author: Anna Zubenko <[email protected]> Date: Mon Jul 22 07:29:18 2024 +0200 FEAT-990 Mobile landscape mode and functional size sliders (st3v3nmw#998) commit a89a818 Author: 4Source <[email protected]> Date: Mon Jul 22 07:25:45 2024 +0200 [FIX] Cards missing when horizontal rule present in document (st3v3nmw#970) * Use obsidians funtion to extractFrontmatter * Fix line pos shift * Stop using obsidian function because of UnitTest * Add UnitTest for Frontmatter and Horizontal line * Fix linting --------- Co-authored-by: Stephen Mwangi <[email protected]> commit 77f15e1 Author: Carlos Galdino <[email protected]> Date: Mon Jul 22 06:02:11 2024 +0100 Filter due notes when all are scheduled (st3v3nmw#947) Ignore notes due in the future. Fixes st3v3nmw#548 commit 83590be Author: Newdea <[email protected]> Date: Sat Jul 20 15:10:57 2024 +0800 fix st3v3nmw#1000 sidebar indent (st3v3nmw#1001) commit e3a0146 Author: 4Source <[email protected]> Date: Sat Jul 20 09:02:14 2024 +0200 [FIX] Include link parsing for Review context (st3v3nmw#964) * Include link parsing * Fix linting commit 3024264 Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:46 2024 +0200 [FIX] Not scroll back to top after review (st3v3nmw#971) * Update deprecated function * Add scroll back to top * Fix linting commit 1dfd52e Author: 4Source <[email protected]> Date: Sat Jul 20 09:00:33 2024 +0200 [FIX] Folder ignore sorts all folder starting with string (st3v3nmw#972) * Implement isEqualOrSubPath * Implement UnitTest for isEqualOrSubPath * Replace separators with system seperator * Improved seperator replacement commit b175d22 Author: artificialUsagi <[email protected]> Date: Sat Jul 20 14:59:11 2024 +0800 add translation: zh-cn (st3v3nmw#982) * Format & lint * fix: changelog formatting * Post review fixes * Format and lint * Format & lint --------- Co-authored-by: Stephen Mwangi <[email protected]> * chore: update dependencies, linting, & tests * update eslint * lower coverage threshold * minor fixes --------- Co-authored-by: 4Source <[email protected]> Co-authored-by: Ronny Zulaikha <[email protected]>
* first part of translation * end of translation * ran the pnpm thingy
Never got E2E testing to work, remove it. It's laborious to keep up to date anyways.
* fix: parsing code blocks & custom separators This PR: 1. Adds test cases for parsing {{curly}} clozes 2. Fixes st3v3nmw#1072 - Ignore 'cards' in ```block`` & `inline` codeblocks - Adds test cases for both 3. Fixes st3v3nmw#1077 - When all the cloze options aren't being used, `cloze_rules` in `parser.ts` becomes empty which leads to the empty grammar rule `cloze_text` which prevents the grammar from being generated. This change adds a tombstone \0 to address this. - Adds test cases for this * Fixed inline code in clozes * - Fixed issue raised at st3v3nmw#1072 (comment) where inline code was not properly hanlded by clozes - Fixed a new issue related to the case when the user provides empty markers for the inline and multiline cards. With the new version, the rule is disabled when the marker is empty. * add parser test case * add more parser test cases --------- Co-authored-by: Andrea Alberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, it's a bug posted here open-spaced-repetition#76 , which can't show note properly on sidebar, because of Div("nav-file").style.display = "none".