Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovenian language support #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfin
Copy link

@mfin mfin commented Oct 20, 2024

Added all the required files.

@sspanak
Copy link
Owner

sspanak commented Oct 21, 2024

Thanks for you contribution!

The dictionaries from the Hellium repo are generated from subtitles and often contain spelling mistakes, nonsense words or words from other languages, containing foreign characters. I generally avoid using them.

Is there some respected academy or university that regulates the Slovenian language? Usually, they issue something like "the big dictionary of X" (Slovenian, in our case). These dictionaries are guaranteed to be spell-checked and contain some uncommon words, which results in high-quality suggestions. If you know of such dictionary/wordlist I recommend using it instead.

@sspanak sspanak added the languages Dictionary or language related issues label Oct 21, 2024
@mfin
Copy link
Author

mfin commented Oct 25, 2024

Yeah, I didn't find any credible sources. There is one, but it only holds 60k words. I'll leave this open for now (if it's OK with you) and I'll try to find some time to research a bit more over the weekend (maybe start of next week).

@sspanak
Copy link
Owner

sspanak commented Oct 26, 2024

Yeah, I didn't find any credible sources. There is one, but it only holds 60k words. I'll leave this open for now (if it's OK with you) and I'll try to find some time to research a bit more over the weekend (maybe start of next week).

Absolutely, take your time. I am always for high quality work instead quick solutions. Unfortunately, I can not help at the moment, as I am focused on adding East Asian language support. But I do intend to go back to this PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
languages Dictionary or language related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants