Unit test #27
Merged
Unit test #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulusoy
requested changes
Jul 31, 2024
There was a problem hiding this comment.
looks good already!
I would add some more tests:
- if the directory does not contain eml or html files (the list is empty), the function
list_of_filesshould throw an exception (for example, aRunTimeError, or maybe you find a better one - the directory does not exist - here we again need an exception in the original function
- a test that the list only contains eml or html files
Olthoff231381
commented
Jul 31, 2024
|
|
Can I merge this branch? |
|
Ah ok , you want to include the exceptions in the new branch with better test coverage. Ok sure. |
iulusoy
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the first unit test.
Checked that both an empty and a filled dir are detected properly