Improved detecting whether container is window
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's impossible now to change container back to `window` from external code. This fixes the issue. Here is a use case example: one has a responsive web page, and wants infinite scroll bind to window at low resolution but bind to an HTML element at high resolution. There should be a way to switch between these two containers dynamically on window resize.
|
@a-t please include a test for this change |
|
I'm sorry, but I don't quite understand what should be tested. |
|
@a-t create a test that reproduces the bug, then show that the test passes when you make your change |
|
I'm afraid it won't be easy as I'm not familiar with CoffeeScript :( |
|
@a-t the tests are in ES2016 now |
graingert
force-pushed
the
master
branch
2 times, most recently
from
21036ac
to
79473ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's impossible now to change container back to
windowfrom external code viainfinite-scroll-containerattribute. This fixes the issue.Here is a use case example: one has a responsive web page, and wants infinite scroll bind to window at low resolution but bind to an HTML element at high resolution. There should be a way to switch between these two containers dynamically on window resize.