Add new infiniteScrollReset parameter to allow for easier list updates #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2016 15:12
This parameter is needed if you want to reuse the same infinite scroll directive and your items will completely change. A use case is a file browser where you navigate the folder structure and you want all the levels of the hierarchy to benefit from infinite scroll. Without a reset such as this, as soon as you scroll to the bottom of the list, subsequent lists that are not bigger than that will no longer have infinite scroll. You can call the reset by adding an event listener and setting the reset to true. e.g. <div infinite-scroll="addMoreItems()" infinite-scroll-listen-for-event="list:changed" infinite-scroll-reset="true"> [...] </div>
|
@tricinel please add tests and documentation for this change, and squash + rebase. |
graingert
force-pushed
the
master
branch
2 times, most recently
from
21036ac
to
79473ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is needed if you want to reuse the same infinite scroll directive and your items will completely change. A use case is a file browser where you navigate the folder structure and you want all the levels of the hierarchy to benefit from infinite scroll. Without a reset such as this, as soon as you scroll to the bottom of the list, subsequent lists that are not bigger than that will no longer have infinite scroll.
You can call the reset by adding an event listener and setting the reset to true. e.g.