-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GUI plugin to control wave environment #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the gui_system_plugin example as a starting point Signed-off-by: Rhys Mainwaring <[email protected]>
- Add checkboxes and parameter fields Signed-off-by: Rhys Mainwaring <[email protected]>
- Add checkboxes and callbacks for adding and removing markers Signed-off-by: Rhys Mainwaring <[email protected]>
- Publish a param.proto message containing the wave params Signed-off-by: Rhys Mainwaring <[email protected]>
- Subscribe to params in waves visual. Tile can only be updated on the render thread. Signed-off-by: Rhys Mainwaring <[email protected]>
…plugin - Subscribe to params in waves model plugin. Signed-off-by: Rhys Mainwaring <[email protected]>
- Subscribe to params in wavefield - Revert changes to wave model system plugin (moved update to wavefield). Signed-off-by: Rhys Mainwaring <[email protected]>
- Fix wavefield parameter callback Signed-off-by: Rhys Mainwaring <[email protected]>
- Reverse displacement direction when switching from matrix to cartesian indexing Signed-off-by: Rhys Mainwaring <[email protected]>
- Change default wave angle to agree with model SDF Signed-off-by: Rhys Mainwaring <[email protected]>
- Change wave param topic to be /world/<world>/waves - Modify Wavefield ctor to accept the world name as parameter - Modify WaveVisual, WaveModel and WaveControl GUI plugin to extract world name from ECM Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring
added a commit
that referenced
this pull request
May 17, 2022
* Initial version of waves control gui plugin - Use the gui_system_plugin example as a starting point Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 2. add parameter fields - Add checkboxes and parameter fields Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 3. add checkboxes for markers - Add checkboxes and callbacks for adding and removing markers Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 4. publish wave params message - Publish a param.proto message containing the wave params Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 5. subscribe to wave params in waves visual - Subscribe to params in waves visual. Tile can only be updated on the render thread. Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 6. subscribe to wave params in waves model plugin - Subscribe to params in waves model plugin. Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 6. subscribe to wave params in wavefield - Subscribe to params in wavefield - Revert changes to wave model system plugin (moved update to wavefield). Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 6. subscribe to wave params in wavefield - Fix wavefield parameter callback Signed-off-by: Rhys Mainwaring <[email protected]> * Fix FFT error in displacements from (#27) - Reverse displacement direction when switching from matrix to cartesian indexing Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 7. change default wave angle - Change default wave angle to agree with model SDF Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 8. obtain world name from ECM - Change wave param topic to be /world/<world>/waves - Modify Wavefield ctor to accept the world name as parameter - Modify WaveVisual, WaveModel and WaveControl GUI plugin to extract world name from ECM Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 9. disable debug prints Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 10. remove unused code Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring
added a commit
that referenced
this pull request
May 17, 2022
* Add GUI plugin to control wave environment (#31) * Initial version of waves control gui plugin - Use the gui_system_plugin example as a starting point Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 2. add parameter fields - Add checkboxes and parameter fields Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 3. add checkboxes for markers - Add checkboxes and callbacks for adding and removing markers Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 4. publish wave params message - Publish a param.proto message containing the wave params Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 5. subscribe to wave params in waves visual - Subscribe to params in waves visual. Tile can only be updated on the render thread. Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 6. subscribe to wave params in waves model plugin - Subscribe to params in waves model plugin. Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 6. subscribe to wave params in wavefield - Subscribe to params in wavefield - Revert changes to wave model system plugin (moved update to wavefield). Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 6. subscribe to wave params in wavefield - Fix wavefield parameter callback Signed-off-by: Rhys Mainwaring <[email protected]> * Fix FFT error in displacements from (#27) - Reverse displacement direction when switching from matrix to cartesian indexing Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 7. change default wave angle - Change default wave angle to agree with model SDF Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 8. obtain world name from ECM - Change wave param topic to be /world/<world>/waves - Modify Wavefield ctor to accept the world name as parameter - Modify WaveVisual, WaveModel and WaveControl GUI plugin to extract world name from ECM Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 9. disable debug prints Signed-off-by: Rhys Mainwaring <[email protected]> * Waves control GUI plugin: 10. remove unused code Signed-off-by: Rhys Mainwaring <[email protected]> * Add GUI plugin to control wave environment - header migration Signed-off-by: Rhys Mainwaring <[email protected]>
16 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GUI plugin to control the wave environment. This version allows the wind speed and wind angle parameters for the ECKV cosine-2S spectrum to be adjusted at run time.
There are placeholders for toggling the waterline, water patch and submerged triangle marker visuals, but they are not activated in this PR.
Closes #30
Usage
Build:
Configure:
Run:
From the sidebar menu select
Waves Control