Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waves: replace CGAL with Eigen in the Wavefield class interface. #128

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Waves: replace CGAL with Eigen in the Wavefield class interface. #128

merged 1 commit into from
Jan 26, 2023

Conversation

srmainwaring
Copy link
Owner

Use Eigen::Vector3d instead of cgal::Point3 in the Wavefield::Height function.

Partially completes #127

@srmainwaring
Waves: replace CGAL with Eigen in the Wavefield class interface.
91c4308 
- Use Eigen::Vector3d instead of cgal::Point3 in the Height function.
- Progress towards using CGAL for internal calculations only.

Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring added the enhancement New feature or request label Jan 24, 2023
@srmainwaring srmainwaring self-assigned this Jan 24, 2023
@srmainwaring srmainwaring merged commit bf9f3d4 into master Jan 26, 2023
@srmainwaring srmainwaring deleted the srmainwaring/wavefield-eigen-height branch January 26, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srmainwaring srmainwaring

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srmainwaring