Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: reconciling schema \w Apollo Meta DB #48

Merged
merged 8 commits into from
Mar 9, 2018
Merged

Refactoring: reconciling schema \w Apollo Meta DB #48

merged 8 commits into from
Mar 9, 2018

Conversation

bzz
Copy link
Contributor

@bzz bzz commented Feb 14, 2018

Addresses #47

First step on the way to allow hash \w Apollo and query \w Gemini

bzz added 2 commits February 14, 2018 13:19
@bzz
Refactoring: extract table name
4ac456c 
Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz
Refactoring: extract column names
acadc56 
Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz bzz mentioned this pull request Feb 14, 2018
Closed
5 tasks
bzz added 2 commits February 16, 2018 00:32
@bzz
Refactoring: using companion object import
568eead 
Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz
Refactoring: cleanup the warnings
21e8f83 
Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz bzz changed the title [WIP] Refactoring: reconciling schema \w Apollo Meta DB Refactoring: reconciling schema \w Apollo Meta DB Mar 2, 2018
@bzz bzz force-pushed the apollo-schema branch from 4a3f268 to 4685675 Compare March 5, 2018 19:29
smacker
smacker approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

P.S. Do you use any formatter or linter for scala, beside default formatter in IntelliJ IDEA? I would be nice if all of us use the same configuration for code style.

This was referenced Mar 6, 2018
Open
Open
@bzz
Copy link
Contributor Author

bzz commented Mar 6, 2018 •
edited
Loading

Thank you for prompt review @smacker ! Indeed, it's only IDE formatter support for now.

Have filed issues for linter/formatter support.

@smacker
Copy link
Contributor

smacker commented Mar 6, 2018

thank you so much!

@bzz bzz force-pushed the apollo-schema branch from 4685675 to 32308b3 Compare March 6, 2018 21:45
@bzz
Copy link
Contributor Author

bzz commented Mar 6, 2018

History was re-written but only last 2 commits were actually added, to include same changes in Golang query implementation.

@bzz bzz force-pushed the apollo-schema branch 2 times, most recently from 5a78be4 to 6843475 Compare March 6, 2018 22:01
@bzz
Go - add query to CI integration test
8f734c5 
Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz bzz force-pushed the apollo-schema branch from 6843475 to 8f734c5 Compare March 6, 2018 22:54
@bzz bzz requested a review from carlosms March 7, 2018 05:57
@bzz
Copy link
Contributor Author

bzz commented Mar 9, 2018

Merging, if there is no further discussion

@bzz bzz merged commit 17b4c93 into src-d:master Mar 9, 2018
@bzz bzz deleted the apollo-schema branch March 9, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosms carlosms carlosms approved these changes

@smacker smacker smacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzz @smacker @carlosms