refactoring: remove un-used code, add go doc #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
reviewed
Feb 4, 2019
creachadair
reviewed
Feb 4, 2019
creachadair
approved these changes
Feb 4, 2019
Refactoring, consisting of - remove unused method `isAuxiliaryLanguage` and `FileCountList` in order to reduce public API surfaces (go/java) - add GoDoc to public APIs TEST PLAN: - make test Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
bzz
force-pushed
the
refactoring/api-surface-docs
branch
from
d530369 to
f93d23e
Compare
|
@creachadair addressed in f93d23e Waiting for a green CI before merge. |
It also now mimics https://docs.travis-ci.com/user/languages/go/#go-import-path for non-go build image, as code relis oninternal imports. Signed-off-by: Alexander Bezzubov <[email protected]>
bzz
force-pushed
the
refactoring/api-surface-docs
branch
from
5402d95 to
8ffdf51
Compare
|
Java UnitTest CI fixed in 8ffdf51, PR description updated. |
creachadair
approved these changes
Feb 5, 2019
Co-Authored-By: bzz <[email protected]>
bzz
added a commit
to bzz/enry
that referenced
this pull request
Feb 20, 2019
Refactoring, consisting of - remove unused method `isAuxiliaryLanguage` and `FileCountList` in order to reduce public API surfaces (go/java) - add GoDoc to public APIs - ci: java profile use latest go src It also now mimics https://docs.travis-ci.com/user/languages/go/#go-import-path for non-go build image, as code relies on internal imports. TEST PLAN: - make test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring, consisting of
isAuxiliaryLanguageandFileCountListin order to reduce public API surfaces (go/java)
It actually uses latest go code now + does not depend on GH org name (by mimicking
go_import_path)
TEST PLAN: