Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with [docker-compose up] command #146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rizahmeds
Copy link

Pull Request Title

Fixed issue, while running command docker-compose up locally.

Related Issue

Fixes #144

Description

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • Change python base-image from python:3.11.0-slim to python:3.11-slim-bullseye
  • Remove unnecessary RUNs

Screenshots / Code Snippets (if applicable)

Screenshot 2023-09-13 at 18 49 52

How to Test

  1. docker-compose up

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

@rizahmeds rizahmeds changed the title fix: issue with docker-compose up command fix: issue with [docker-compose up] command Sep 13, 2023
@srbhr
Copy link
Owner

srbhr commented Sep 14, 2023

Hi @rizahmeds I'll take a look at it.
Thanks for the PR.

@srbhr
Copy link
Owner

srbhr commented Sep 21, 2023

Hi @rizahmeds
I'm unable to get this running properly in my local. I'll ask in the discord for anyone to test it out.

@rizahmeds
Copy link
Author

Hi @rizahmeds I'm unable to get this running properly in my local. I'll ask in the discord for anyone to test it out.

Alright @srbhr Thanks!

@SubramanyamChalla24
Copy link
Contributor

hi @rizahmeds , I was getting the below error when i test your code
image
I think it is an issue with the python version. can you test from your end and verify if it working? are you able to get the similarity score when you are using the config file?

@rizahmeds
Copy link
Author

rizahmeds commented Sep 27, 2023

Hi @SubramanyamChalla24, Thanks for pointing this out.
This error is due to older version of QdrantClient which didn't had url parameter.
Make sure you have qdrant-client>=1.2 in virtualenv or docker container.
(Note: Please do pip list to check qdrant-client version installed)

@srbhr Now i am just wondering, why config.yml have been remove from scripts/similarity path, because we still reading the config file here in this line of code

Screenshot 2023-09-27 at 22 29 08

@SubramanyamChalla24
Copy link
Contributor

Now i am just wondering, why config.yml have been remove from scripts/similarity path, because we still reading the config file here in this line of code

That is because the user needs to add the config file manually as it contains the private api keys.

@rizahmeds
Copy link
Author

@SubramanyamChalla24
Make sense. Earlier we only needed to replace the values that's why I got confused 😅

@SubramanyamChalla24
Copy link
Contributor

This error is due to older version of QdrantClient which didn't had url parameter. Make sure you have qdrant-client>=1.2 in virtualenv or docker container. (Note: Please do pip list to check qdrant-client version installed)

I have the latest version. It's not an error with the version though. can you check from your side including the config file?

@rizahmeds
Copy link
Author

rizahmeds commented Sep 27, 2023

Yes, i already checked with the config.yaml file.
Since I do not have the cohere API key(Because it requires me to add a credit card detail, which I don't have 🥺), it raises another exception for me. So I can't completely test it.

@SubramanyamChalla24
Copy link
Contributor

Cohere doesn't require a credit card. Can you check it once?It required a card before but it doesn't need it now.

Yes, i already checked with the config.yaml file. Since I do not have the cohere API key(Because it requires me to add a credit card detail, which I don't have 🥺), it raises another exception for me. So I can't completely test it.

@rizahmeds
Copy link
Author

Thanks for the update @SubramanyamChalla24. Yes i have got the Cohere Trial key.
Then i reinitialized qdrant cluster which was suspended. Here you go, Finished getting similarity score.

Screenshot 2023-09-28 at 00 31 26

@srbhr
Copy link
Owner

srbhr commented Sep 28, 2023

Great work in collaboration @rizahmeds and @SubramanyamChalla24 🔥
I like the teamwork here.
So, is this PR working now?

@SubramanyamChalla24
Copy link
Contributor

So, is this PR working now?

I couldn't replicate it. It still shows the same error though. Probably someone has to try and verify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with docker pull
3 participants