Generic/OpeningFunctionBrace*: check spacing before brace for empty functions #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace for empty functions As things were, when an empty function was detected, the sniff would bow out and not execute the "SpaceBeforeBrace" check. Fixed now. Includes tests.
… empty functions As things were, when an empty function was detected, the sniff would bow out and not execute the "BraceIndent" check. Fixed now. Includes tests.
fredden
approved these changes
Aug 14, 2023
5 tasks
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#80 |
jrfnl
deleted the
feature/generic-openingfunctionbrace-check-space-before-brace
branch
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically this is the same fix for both sniffs. The sniffs would
return, instead of skip over a particular check, which meant that other checks after the check which needed to be skipped were not being run.Generic/OpeningFunctionBraceKernighanRitchie: check spacing before brace for empty functions
As things were, when an empty function was detected, the sniff would bow out and not execute the "SpaceBeforeBrace" check.
Fixed now.
Includes tests.
Generic/OpeningFunctionBraceBsdAllman: check spacing before brace for empty functions
As things were, when an empty function was detected, the sniff would bow out and not execute the "BraceIndent" check.
Fixed now.
Includes tests.
Suggested changelog entry
Types of changes