Add option for inequal distributions of workload #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been busy and will check this next week. |
dopefishh
reviewed
Feb 12, 2020
dopefishh
reviewed
Feb 12, 2020
| @@ -1,28 +1,52 @@ | |||
| #! /bin/bash | |||
|
|
|||
| # partition ALL SUBDIRECTORIES in equal parts into the folders given as arguments | |||
|
|
|||
dopefishh
reviewed
Feb 12, 2020
| echo "dir: $1" | ||
| shift | ||
| echo "val: $1" | ||
| distribution[$((i++%N))]=$(echo "$1*$numFolders" | bc | mawk '{print int($1+0.5)}') |
There was a problem hiding this comment.
does this really need mawk? or can bc or any awk do this?
dopefishh
reviewed
Feb 12, 2020
| until [ -z "$1" ]; do | ||
| # temporarily hide the folders we are sorting into | ||
| test -d "$1" && mv "$1" ".$1" | ||
| mkdir -p ".$1" | ||
| dir[$((i++%N))]="$1" | ||
| dir[$((i%N))]="$1" | ||
| echo "dir: $1" |
There was a problem hiding this comment.
Are these prints necessary
dopefishh
reviewed
Feb 12, 2020
| @@ -1,6 +1,6 @@ | |||
| #! /bin/bash | |||
|
|
|||
| # TODO: | |||
| # TODO: | |||
dopefishh
reviewed
Feb 12, 2020
| email[marc]="[email protected]" | ||
| #email[ko]="[email protected]" | ||
| #email[pol]="[email protected]" | ||
| typeset -A distribution |
There was a problem hiding this comment.
let's keep using the marc/ko/pol example graders, they deserve it:')
dopefishh
reviewed
Feb 12, 2020
| @@ -120,7 +123,7 @@ if [ "$CSV" ]; then | |||
| "$MYDIR"/identify.sh "$CSV" */ | |||
| fi | |||
|
|
|||
| echo | |||
| echo | |||
dopefishh
reviewed
Feb 12, 2020
| @@ -186,8 +208,8 @@ do | |||
| echo Mailing "$ta" | |||
| pkt="$ta-${zip%.zip}.7z" | |||
| 7za a -ms=on -mx=9 "$pkt" "$ta" > /dev/null | |||
| #echo "$humor" | mailx -n -s "${SUBJECT} ${zip%.zip}" -a "$pkt" "${email[$ta]}" | |||
| echo "$humor" | mutt -s "${SUBJECT}: ${zip%.zip}" -a "$pkt" -- "${email[$ta]}" | |||
| #echo "$humor" | mailx -n -s "${SUBJECT} ${zip%.zip}" -a "$pkt" "${email[$ta]}" | |||
|
Oh yeah, thats my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm currently working as a TA for functional programming for AI.
We had an issue that one of the TAs should have a higher workload than the others.
Our quick fix was of course to add the TAs multiple times which is very annoying because everyone would get multiple emails etc.
Anyway long story short, I made some changes to introduce an (optional) distribution array which allows the script to partition the work. It works perfectly in my tests but I haven't done much bash scripting before so it might have some bugs that I missed.
Hope it's something you guys approve of