Rework clear_status status to support newer STM32 devices
#10
+53
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrown1867
commented
Oct 21, 2024
| @@ -153,7 +178,8 @@ def _dfu_download( | |||
| xfer_size: Transfer size to use when downloading. | |||
| """ | |||
| # Download data | |||
| with Progress() as progress: | |||
| progress = Progress() | |||
There was a problem hiding this comment.
Started getting a weird mypy error and this change fixed it. 🤷🏻
bbrown1867
commented
Oct 21, 2024
| @@ -12,7 +12,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ ubuntu-latest, macos-latest ] | |||
| python-version: [ 3.7, 3.8, 3.9 ] | |||
| python-version: [ 3.9, 3.11, 3.12 ] | |||
There was a problem hiding this comment.
3.10 seemed to be interpreted as 3.1 by the CI runner, not sure why. Skipping since I don't think we need the coverage of 3.10 anyways.
bbrown1867
force-pushed
the
bbrown1867/fix-double-update-issue
branch
from
5a63542
to
86782ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain the changes you made here.
Attempting to use this package with a newer STM32 device (not an F-series) gave an issue - the first download attempt would fail with a pipe error.
I tried removing the
dfu.clear_status(dev, interface)call and that fixed it, but then it caused a regression on STM32F2. To make both types of devices work, I reworked theclear_statuscall to be a retry step only if necessary.I also discovered the infrastructure in this repo was outdated and needed updating. The new minimum version of Python is 3.9 and a few packages were updated.
Does this close any currently open issues?
No
Checklist: